Fabrika/PersonalBlog
8
0
Fork 1
Code Issues 305 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

fix: align app/db image bases with documented stack (E00-S02-T01)
CI / Frozen lockfile install (pull_request) Successful in 48s
Details

Browse Source 
Switch the app image from node:24-alpine to node:24.19.0-bookworm-slim in
both build and runtime stages (Technology-Stack 5.4: glibc Debian base
required because argon2 is a native dependency; musl/Alpine causes
native-module build surprises), and the db image from postgres:16-alpine
to postgres:18-bookworm (Technology-Stack 5.2/5.4/6.2 + golden tuple 7
pin PostgreSQL 18.6; 18-bookworm is the 18.x line on Debian bookworm).

Update tests/compose-config.test.mjs so the committed assertions lock in
the corrected image bases (db image, Dockerfile build/runtime stages,
parser probe).
This commit is contained in:
implementer
2026-08-28 23:45:18 +00:00
parent 3be575818d
commit 3bbea68e6c
3 changed files with 22 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/compose-config.test.mjs
+11 -10
View File
@@ -13,8 +13,9 @@
* container is up.
* - "docker compose up -d starts the application" → the committed
* `compose.yaml` declares an `app` service built from the committed
* `apps/server/Dockerfile` (multi-stage: Node 24 + frozen pnpm install →
* `tsc` build of `@personal-blog/server` → `node apps/server/dist/index.js`),
* `apps/server/Dockerfile` (multi-stage: Node 24.19.0 bookworm-slim +
* frozen pnpm install → `tsc` build of `@personal-blog/server` →
* `node apps/server/dist/index.js`),
* with a published default port and `depends_on: db` so the application
* starts after the database. The real-stack probe asserts the `app`
* container is created and starts cleanly (exit 0 when the placeholder
@@ -158,8 +159,8 @@ function assertDbService(compose) {
assert.ok(db, 'compose.yaml must declare a "db" service (docker compose up -d starts the database)');
assert.equal(
db.image,
'postgres:16-alpine',
'the "db" service must use the committed PostgreSQL image (postgres:16-alpine)',
'postgres:18-bookworm',
'the "db" service must use the committed PostgreSQL 18 image (postgres:18-bookworm)',
);
const env = db.environment ?? {};
assert.equal(env.POSTGRES_DB, '${POSTGRES_DB:-eppp}', 'db must set POSTGRES_DB (with a default)');
@@ -291,13 +292,13 @@ test('the application image is defined by a committed multi-stage Dockerfile', (
const dockerfile = read(DOCKERFILE_PATH);
assert.match(
dockerfile,
/FROM node:24-alpine AS build/,
'the Dockerfile must build on the committed Node 24 line (FROM node:24-alpine AS build)',
/FROM node:24\.19\.0-bookworm-slim AS build/,
'the Dockerfile must build on the committed Node 24.19.0 bookworm-slim base (FROM node:24.19.0-bookworm-slim AS build)',
);
assert.match(
dockerfile,
/FROM node:24-alpine AS runtime/,
'the Dockerfile must ship a slim Node 24 runtime stage (FROM node:24-alpine AS runtime)',
/FROM node:24\.19\.0-bookworm-slim AS runtime/,
'the Dockerfile must ship a Node 24.19.0 bookworm-slim runtime stage (FROM node:24.19.0-bookworm-slim AS runtime)',
);
assert.match(
dockerfile,
@@ -394,7 +395,7 @@ test('the YAML parser reads the committed structure (non-vacuous parser probe)',
const parsed = parseYaml(`
services:
db:
image: postgres:16-alpine
image: postgres:18-bookworm
environment:
POSTGRES_DB: eppp
ports:
@@ -406,7 +407,7 @@ services:
depends_on:
- db
`);
assert.equal(parsed.services.db.image, 'postgres:16-alpine');
assert.equal(parsed.services.db.image, 'postgres:18-bookworm');
assert.equal(parsed.services.db.environment.POSTGRES_DB, 'eppp');
assert.deepEqual(parsed.services.db.ports, ['5432:5432']);
assert.equal(parsed.services.app.build.dockerfile, 'apps/server/Dockerfile');