• Joined on 2022-09-18
kpcto commented on issue Fabrika/PersonalBlog#183 2026-08-30 03:31:53 +00:00
[E00-S04-T02] Missing required setting gives field-specific startup error
agent: reviewer
verdict: approve
reviewed:
  pr: 397
  issue: 183
  head_branch: feature/183
  head_sha: 873264004a5727af1e4f8b45dc86fab8d16185b9
summary: 
kpcto closed issue Fabrika/PersonalBlog#182 2026-08-30 02:44:06 +00:00
[E00-S04-T01] TypeBox/Ajv schema
kpcto deleted branch feature/182 from Fabrika/PersonalBlog 2026-08-30 02:42:57 +00:00
kpcto pushed to main at Fabrika/PersonalBlog 2026-08-30 02:42:57 +00:00
ecc945ce65 Merge pull request '[E00-S04-T01] TypeBox/Ajv schema' (#396) from feature/182 into main
5eff1580ac docs: document the config package in the non-container guide (E00-S04-T01)
ce0d3c0d44 test: lock in the config schema with static, mutation and deterministic probes (E00-S04-T01)
bcea489391 feat: add TypeBox/Ajv config schema package to the workspace (E00-S04-T01)
Compare 4 commits »
kpcto merged pull request Fabrika/PersonalBlog#396 2026-08-30 02:42:56 +00:00
[E00-S04-T01] TypeBox/Ajv schema
kpcto closed issue Fabrika/PersonalBlog#181 2026-08-30 02:12:03 +00:00
[E00-S03-T06] App does not report ready before migrations complete
kpcto pushed to main at Fabrika/PersonalBlog 2026-08-30 02:09:51 +00:00
6a65d4c789 Merge pull request '[E00-S03-T06] App does not report ready before migrations complete' (#395) from feature/181 into main
5b0bded4b4 docs: document the readiness gate in the non-container guide (E00-S03-T06)
c20110be15 test: lock in the app readiness gate with static, deterministic and real-stack probes (E00-S03-T06)
ebdee5daa5 feat: app reports ready only after the startup migration run (E00-S03-T06)
Compare 4 commits »
kpcto deleted branch feature/181 from Fabrika/PersonalBlog 2026-08-30 02:09:51 +00:00
kpcto merged pull request Fabrika/PersonalBlog#395 2026-08-30 02:09:51 +00:00
[E00-S03-T06] App does not report ready before migrations complete
kpcto closed issue Fabrika/PersonalBlog#180 2026-08-30 01:33:00 +00:00
[E00-S03-T05] Migration failure produces structured diagnostic
kpcto deleted branch feature/180 from Fabrika/PersonalBlog 2026-08-30 01:31:50 +00:00
kpcto pushed to main at Fabrika/PersonalBlog 2026-08-30 01:31:50 +00:00
e8cafa090b Merge pull request '[E00-S03-T05] Migration failure produces structured diagnostic' (#394) from feature/180 into main
bb3a68648a fix: inject the ledger into MigrationRunner (type-only import) so probes load the committed module under type stripping
52190d082c test: lock in the migration failure diagnostic (E00-S03-T05)
f6d407394d feat: add migration runner with structured failure diagnostic (E00-S03-T05)
Compare 4 commits »
kpcto merged pull request Fabrika/PersonalBlog#394 2026-08-30 01:31:49 +00:00
[E00-S03-T05] Migration failure produces structured diagnostic
kpcto closed issue Fabrika/PersonalBlog#179 2026-08-30 01:03:53 +00:00
[E00-S03-T04] Advisory lock prevents concurrent migration runners
kpcto deleted branch feature/179 from Fabrika/PersonalBlog 2026-08-30 01:00:43 +00:00
kpcto pushed to main at Fabrika/PersonalBlog 2026-08-30 01:00:42 +00:00
4f169ace4e Merge pull request '[E00-S03-T04] Advisory lock prevents concurrent migration runners' (#393) from feature/179 into main
cb1b161ce9 fix: destroy the connection on unlock failure so a still-locked session is never reused (E00-S03-T04)
dac3679e33 fix: memoize in-flight acquire so concurrent acquire() is re-entrant-safe (E00-S03-T04)
a2b98439e9 test: lock in the migration advisory lock with static + real-stack probes (E00-S03-T04)
3f80063303 feat: add migration advisory lock to database-postgres (E00-S03-T04)
Compare 5 commits »
kpcto merged pull request Fabrika/PersonalBlog#393 2026-08-30 01:00:40 +00:00
[E00-S03-T04] Advisory lock prevents concurrent migration runners
kpcto commented on issue Fabrika/PersonalBlog#179 2026-08-30 00:40:49 +00:00
[E00-S03-T04] Advisory lock prevents concurrent migration runners
agent: reviewer
verdict: request-changes
reviewed:
  pr: 393
  issue: 179
  head_branch: feature/179
  head_sha: dac3679e33364dcb8453282873b3c424099e6b4f
summary: 
kpcto commented on issue Fabrika/PersonalBlog#179 2026-08-30 00:40:39 +00:00
[E00-S03-T04] Advisory lock prevents concurrent migration runners

Human-maintainer sign-off (kpcto) — resolves security-review finding F1 (pipeline tripwire / needs-human-decision) on PR #393 (head dac3679e).

I approve the new additive `database-postgre…

kpcto closed issue Fabrika/PersonalBlog#178 2026-08-29 23:41:29 +00:00
[E00-S03-T03] Migration ledger created