[E00-S03-T04] Advisory lock prevents concurrent migration runners #393

Merged

kpcto merged 4 commits from feature/179 into main 2026-08-30 01:00:40 +00:00

Conversation 0 Commits 4 Files Changed 7

+1041 -8

4 Commits

Author	SHA1	Message	Date
implementer	cb1b161ce9	fix: destroy the connection on unlock failure so a still-locked session is never reused (E00-S03-T04) ... release() previously returned the connection to the pool in a finally even when the pg_advisory_unlock statement failed, so a pooled connection could be reused while its session still held the migration advisory lock - the next borrower would block every other runner (reviewer finding F4). On unlock failure the connection is now destroyed (client.release(error) removes the client from the pool, ending the session and its lock); the plain client.release() is kept only on the success path. Locked in by a static assertion, a mutation probe, and a deterministic stub-pool behavioral probe of the committed release() control flow.	2026-08-30 00:49:56 +00:00
implementer	dac3679e33	fix: memoize in-flight acquire so concurrent acquire() is re-entrant-safe (E00-S03-T04) ... Security-review finding F2: two concurrent acquire() calls on the same MigrationLock instance could each check out a connection; the second pg_advisory_lock would overwrite this.client, leaking the first locked connection until session end. acquire() now memoizes the in-flight acquire in acquireInFlight and returns it on re-entry, so exactly one connection is checked out and no locked connection leaks. The memo is cleared once the acquire settles. tryAcquire()/release() paths unchanged. Locked in by: - static criterion test: acquireInFlight field, re-entry guard returns the in-flight acquire, memo cleared on settle - mutation probe: removing the re-entry guard fails the criterion - real-stack probe: two concurrent acquire() calls on one instance leave pool.totalCount at 1 (exactly one connection), the lock granted once, nothing left after release; probe fails (hangs) on the pre-fix code - CI job comment updated to reflect the re-entrancy criterion	2026-08-30 00:29:20 +00:00
implementer	a2b98439e9	test: lock in the migration advisory lock with static + real-stack probes (E00-S03-T04)	2026-08-30 00:13:46 +00:00
implementer	3f80063303	feat: add migration advisory lock to database-postgres (E00-S03-T04)	2026-08-30 00:08:57 +00:00